cpoerschke commented on code in PR #3599:
URL: https://github.com/apache/solr/pull/3599#discussion_r2314384772
##########
solr/solrj-zookeeper/src/java/org/apache/solr/client/solrj/cloud/DelegatingCloudManager.java:
##########
@@ -27,10 +25,11 @@
/** Base class for overriding some behavior of {@link SolrCloudManager}. */
public class DelegatingCloudManager implements SolrCloudManager {
protected final SolrCloudManager delegate;
- private ObjectCache objectCache = new ObjectCache();
- private TimeSource timeSource = TimeSource.NANO_TIME;
public DelegatingCloudManager(SolrCloudManager delegate) {
+ if (delegate == null) {
+ throw new IllegalArgumentException("delegate cannot be null");
+ }
Review Comment:
minor: perhaps also mention this in the PR title/commit message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
