dsmiley commented on code in PR #3565:
URL: https://github.com/apache/solr/pull/3565#discussion_r2312479791


##########
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java:
##########
@@ -905,7 +906,61 @@ protected boolean addFL(StringBuilder fl, String field, 
boolean additionalAdded)
     return true;
   }
 
+  protected abstract static class ShardDocQueue {

Review Comment:
   If you do an interface, you could have `ShardFieldSortedHitQueue` implement 
that interface.  Then, `DefaultShardDocQueue` could be removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to