[ 
https://issues.apache.org/jira/browse/SOLR-17560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18017026#comment-18017026
 ] 

ASF subversion and git services commented on SOLR-17560:
--------------------------------------------------------

Commit d260f0fb55ed5864d14711ed018e15d220f371e4 in solr's branch 
refs/heads/main from Meryem Gülbudak
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=d260f0fb55e ]

SOLR-17560: Remove redundant getLeaderReplicas method (#3515)

To simplify & reduce weight of DocCollection.  This method was only called in 
one place and it doesn't seem worthy.

> DocCollection, don't need getLeaderReplicas(nodeName)
> -----------------------------------------------------
>
>                 Key: SOLR-17560
>                 URL: https://issues.apache.org/jira/browse/SOLR-17560
>             Project: Solr
>          Issue Type: Task
>          Components: SolrCloud
>            Reporter: David Smiley
>            Priority: Minor
>              Labels: newdev, pull-request-available
>             Fix For: main (10.0)
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Claim: DocCollection.getLeaderReplicas(nodeName) isn't needed.
> Goal:  reduce complexity/bookkeeping and weight of DocCollection
> In non-test code, it's only needed by 
> org.apache.solr.servlet.HttpSolrCall#getCoreByCollection for an indexing 
> request.  This could be modified to randomly iterate all replicas and filter 
> leaders afterwards instead of before.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to