epugh commented on code in PR #3503: URL: https://github.com/apache/solr/pull/3503#discussion_r2296672385
########## solr/solrj/src/resources/DeprecatedSystemPropertyMappings.properties: ########## @@ -19,3 +19,4 @@ solr.enable.remote.streaming=solr.requests.streaming.remote.enabled solr.enable.stream.body=solr.requests.streaming.body.enabled solr.delete.unknown.cores=solr.cloud.startup.delete.unknown.cores.enabled solr.config.set.forbidden.file.types=solr.configset.forbidden.file.types +solr.hide.stack.trace=solr.responses.stacktrace.enabled Review Comment: Not a bad idea.. Maybe if the line starts with a `!` then you know while processing that it's an inversion. That would simplify the rule logic in EnvUtils.java.. This is a great idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
