mlbiscoc commented on PR #3482: URL: https://github.com/apache/solr/pull/3482#issuecomment-3206972914
> The SolrIndexSearcher is created often; on every commit. Will reregistering metrics simply overwrite the previously registered metrics without issue? Thats a good question that I haven't actually ran into... But observable instruments are the only OTEL instruments that are `closable` without having to teardown the registry. So maybe what we should do instead is keep a reference of these then in the `close()` method, teardown and close all these observable instruments when the searcher closes to make sure they are closed instead of betting on an overwrite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
