abumarjikar commented on code in PR #3479:
URL: https://github.com/apache/solr/pull/3479#discussion_r2282001010
##########
solr/core/src/java/org/apache/solr/handler/admin/api/CreateCollection.java:
##########
@@ -291,10 +292,10 @@ private static void createSysConfigSet(CoreContainer
coreContainer)
}
public static CreateCollectionRequestBody createRequestBodyFromV1Params(
- SolrParams params, boolean nameRequired) {
+ SolrParams params, boolean nameRequired, Optional<String> propertyName) {
final var requestBody = new CreateCollectionRequestBody();
- requestBody.name =
- nameRequired ? params.required().get(CommonParams.NAME) :
params.get(CommonParams.NAME);
+ final var NAME = propertyName.orElse(CommonParams.NAME);
Review Comment:
changes done to reduce the overhead of using other option. just provided
what is need for create collection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
