[ 
https://issues.apache.org/jira/browse/SOLR-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18014411#comment-18014411
 ] 

ASF subversion and git services commented on SOLR-17672:
--------------------------------------------------------

Commit cc887f5d6cc44ea84e1c192f99b5ea09e1bfdac0 in solr's branch 
refs/heads/main from Christos Malliaridis
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=cc887f5d6cc ]

SOLR-17672: Enable spotless for Kotlin files (#3450)

* Add spotless for kotlin and kotlin DSL (multiplatform)

* Format source code

* Add explicit import layout rule

Add explicit import layout rule with alphabetical ordering and alias imports at 
the end.

> Enable spotless in new UI
> -------------------------
>
>                 Key: SOLR-17672
>                 URL: https://issues.apache.org/jira/browse/SOLR-17672
>             Project: Solr
>          Issue Type: Improvement
>          Components: Admin UI
>            Reporter: Christos Malliaridis
>            Assignee: Christos Malliaridis
>            Priority: Major
>              Labels: gradle, new-ui, newdev, pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The new UI module was introduced with minimal configuration changes. As 
> result, some tooling has not been configured to apply on the new 
> multiplatform module, including spotless.
> h2. Task
> Enable and configure spotless to use ktlint with default configuration.
> h2. Acceptance Criteria
> - The UI module classes (main and test) are formatted
> - Whenever spotless runs, it checks the formatting
> - *.gradle.kts files are formatted
> h2. Additional Information
> You can find example configurations here:
> https://github.com/diffplug/spotless/tree/main/plugin-gradle#kotlin
> Spotless can use ktlint, and since we are using Compose too, some custom 
> rulesets may have to be added and adjusted via the .editorconfig. A set of 
> custom rules that we can use is https://mrmans0n.github.io/compose-rules/
> Note that we are currently configuring spotless in 
> {{/gradle/validation/spotless.gradle}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to