dsmiley commented on code in PR #3469:
URL: https://github.com/apache/solr/pull/3469#discussion_r2279076341
##########
solr/core/src/java/org/apache/solr/handler/component/SpellCheckComponent.java:
##########
@@ -875,17 +875,7 @@ public Map<String, SolrSpellChecker> getSpellCheckers() {
return Collections.unmodifiableMap(spellCheckers);
}
- // ///////////////////////////////////////////
- // / SolrInfoBean
- // //////////////////////////////////////////
-
- @Override
public String getDescription() {
Review Comment:
can getDescription be removed if we don't implement SolrInfoBean?
##########
solr/core/src/java/org/apache/solr/handler/component/HighlightComponent.java:
##########
@@ -240,20 +240,11 @@ public void finishStage(ResponseBuilder rb) {
}
}
- ////////////////////////////////////////////
- /// SolrInfoBean
Review Comment:
fine; we generally don't use such method organizational headings. It may be
is only useful in larger classes... granted growth happens organically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
