ercsonusharma commented on PR #3418: URL: https://github.com/apache/solr/pull/3418#issuecomment-3165339477
@aruggero Thanks for the review and posting the feedback. Here is the response to it: > A) 1) The maxCombinerQueries parameter. This is a parameter with no "right" value to set; it would be better just to let the user manage by themselves. Agreed, that there is no right value that's why it's upto user to choose that value through solrConfig. But, there has to be some default upper value set, right? >A) 2) Supporting more than one combiner is not necessary by now since only Reciprocal Rank Fusion is currently present. It's not necessary but good to have feature from beginnning itself so that can be extended later on through plugins. >A) 3) The cursorMark usage for pagination could be something added a second time with a dedicated pull request. We could start as simply as possible. Agreed and I didn't implement in a neat way (just propagated the cursorMark to all responseBuilders). Left it for other PR but I missed adding in the doc which I do so. >B)Could you explain to us the overall general idea of your implementation? There are some points, as also mentioned by Christine, which are intricate and hard to review. Could you help us understand the purpose of each part and how they interact? Did you mean general idea and purpose about the PR implementation? I can explain in detail if description doesn't help. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
