mlbiscoc commented on PR #3384: URL: https://github.com/apache/solr/pull/3384#issuecomment-2977412580
> The introduction of use of OTEL's "scope" will be very interesting & foundational to Solr's adoption of OTEL metrics. I think that's the next step after this PR. This PR already has "scope" in the metrics. All metrics have a tag called `otel_scope_name`. When creating an instrument from `SolrMetricsContext`, it has to create the instrument from a `scope` to `SolrMetricManager` which is the registry name that the SolrMetricsContext holds. Unless we want scope to be something else, I am keeping it the same registries or "scope` which is `solr.node`, `solr.core.*`, `solr.jetty`... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
