[
https://issues.apache.org/jira/browse/SOLR-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950745#comment-17950745
]
Rahul Goswami edited comment on SOLR-7962 at 5/11/25 7:32 AM:
--------------------------------------------------------------
Thanks for offering to review [~epugh] . The pull request is ready for review.
Will add the tests next.
"-e" now works with "-jvm-opts" on Windows. For the specific case of remote
debug config (-agentlib:jdwp=transport=...), cmd.exe was not playing well with
commons-exec's default way of parsing, passing incorrect/incomplete values to
start.cmd.
Also fixed an edge case issue where passing a \-D system property as a value
for --jvm-opts would cause the command to bail. So now passing something like
--jvm-opts "-Dsolr.myprops.custom=hello" works. Also tested passing multiple
args like --jvm-opts "-Dsolr.myprops.custom=hello
-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:18983" and that
works too.
was (Author: rahul196...@gmail.com):
Thanks for offering to review [~epugh] . The pull request is ready for review.
Will add the tests next.
"-e" now works with "-jvm-opts" on Windows. For the specific case of remote
debug config (-agentlib:jdwp=transport=...), cmd.exe was not playing well with
commons-exec's default way of parsing, passing incorrect/incomplete values to
start.cmd.
Also fixed an edge case issue where passing a -D system property as a value
for--jvm-opts would cause the command to bail. So now passing something like
--jvm-opts "-Dsolr.myprops.custom=hello" works. Also tested passing multiple
args like --jvm-opts "-Dsolr.myprops.custom=hello
-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:18983" and that
works too.
> Passing additional arguments to solr.cmd using "-a" does not work on Windows
> ----------------------------------------------------------------------------
>
> Key: SOLR-7962
> URL: https://issues.apache.org/jira/browse/SOLR-7962
> Project: Solr
> Issue Type: Bug
> Affects Versions: 5.3
> Reporter: Dawid Weiss
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
