dsmiley commented on code in PR #3340:
URL: https://github.com/apache/solr/pull/3340#discussion_r2075967221
##########
solr/core/src/java/org/apache/solr/search/SolrReturnFields.java:
##########
@@ -547,6 +547,12 @@ private void addField(
String disp = (key == null) ? field : key;
augmenters.addTransformer(new MatchScoreAugmenter(disp));
scoreDependentFields.put(disp, disp.equals(MATCH_SCORE) ? "" :
MATCH_SCORE);
+ } else if (key != null && isPseudoField) {
+ // SOLR-15030: a pseudo-field based on the function query may need
scores,
+ // so we consider all pseudo-fields as potentially requiring scores.
+ // At the same time, we don't set _wantScore = true because the field
+ // list must explicitly include 'score' field to enable scores
Review Comment:
I assume that the work-around to `DocTransformer.needsScores` not existing
is that the user should explicitly add `score` to `fl`?
Lucene standardizes on `needsScores` terminology. Solr ReturnFields &
ResultContext has "wants" terminology.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
