dsmiley commented on PR #1244: URL: https://github.com/apache/solr/pull/1244#issuecomment-2855399596
Updating the PR to main was easy. Note that there is another PR #3340 that will overlap with this one which makes it possible for a DocTransformer to access the score. The failing tests relate to sorting by an expression that makes use of the score. If we mark those tests with an `Ignore` and add a follow-up to improve that matter, then I think we have something mergeable. Progress not perfection; right? Addressing the score issue is complicated by the fact that Lucene's `ValueSource` API is legacy, has no concept of `needsScores`, but the replacement `DoubleValuesSource` _does_ have this concept. Solr is still ValueSource based. I could see doing a switch for Solr 10 but that's for another issue and dev list discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
