stillalex commented on code in PR #2687:
URL: https://github.com/apache/solr/pull/2687#discussion_r2066367300
##########
solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/TestDistributedTracing.java:
##########
@@ -39,24 +39,22 @@
import org.apache.solr.cloud.SolrCloudTestCase;
import org.apache.solr.common.SolrDocumentList;
import org.apache.solr.util.tracing.TraceUtils;
-import org.junit.AfterClass;
import org.junit.Before;
import org.junit.BeforeClass;
+import org.junit.ClassRule;
import org.junit.Test;
public class TestDistributedTracing extends SolrCloudTestCase {
private static final String COLLECTION = "collection1";
+ @ClassRule public static OpenTelemetryRule otelRule =
OpenTelemetryRule.create();
Review Comment:
this is pretty cool, I did not know this existed.
##########
solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/BasicAuthIntegrationTracingTest.java:
##########
@@ -31,23 +33,23 @@
import org.apache.solr.security.BasicAuthPlugin;
import org.apache.solr.util.SecurityJson;
import org.apache.solr.util.tracing.TraceUtils;
-import org.junit.AfterClass;
import org.junit.BeforeClass;
+import org.junit.ClassRule;
import org.junit.Test;
public class BasicAuthIntegrationTracingTest extends SolrCloudTestCase {
private static final String COLLECTION = "collection1";
+ @ClassRule public static OpenTelemetryRule otelRule =
OpenTelemetryRule.create();
Review Comment:
this is pretty cool, I did not know this existed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
