janhoy commented on PR #3291: URL: https://github.com/apache/solr/pull/3291#issuecomment-2814059047
Coming back to this. Lacking test suite on multiple windows versions makes such changes brittle. I hope the iterations we have done here and the reviews is enough to merge. And then hope the fix is not worse than what it replaces, except for perhaps added latency launching powershell. I'll go ahead and merge to main for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
