David Smiley created SOLR-17735:
-----------------------------------

             Summary: Http2SolrClient (Jetty HttpClient) should use 
QueuedThreadPool
                 Key: SOLR-17735
                 URL: https://issues.apache.org/jira/browse/SOLR-17735
             Project: Solr
          Issue Type: Improvement
          Components: clients - java
            Reporter: David Smiley


By default, a Jetty HttpClient uses its own QueuedThreadPool (a 
java.util.Executor), and _appears_ very impressive (high performance).  Yet 
Solr Http2SolrClient insists on using an ExecutorService of its own creation, 
basically a generic one adorned with Solr's standard MDC passing and other 
miscellaneous things.  I think Solr should let Jetty be Jetty and not overly 
customize things.  The MDC and misc stuff seems unnecessary for this executor.  
Furthermore, the "withExecutor" should allow merely an Executor and not insist 
on an ExecutorService.

Perhaps a change like this would show a positive performance improvement in the 
benchmarks.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to