dsmiley commented on PR #3263: URL: https://github.com/apache/solr/pull/3263#issuecomment-2736545415
Yeah it's too late to break up. If we could wind back the clock with the benefit of hindsight, we could do something specific broadly. Like remove the silly toAbsolutePaths by themselves. But why bother break this up at this point? Too much effort for too little gain. Just need to struggle through a big PR review. The **tools** really struggle (GitHub UI), GitHub plugin to IntelliJ. Well; progress not perfection. I admit I can be a perfectionist in my feedback but that doesn't mean this PR needs to balloon in scope either. I would like this PR to try to not add more calls to FilterPath.unwrap if it can be helped. And to not add more calls to Path.of or Paths.get where it's not suitable to do so. And referencing FileSystem.getDefault() when some nearby path.getFileSystem() can be used. But these could be addressed in a follow-up aiming at that as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
