mlbiscoc commented on code in PR #3300:
URL: https://github.com/apache/solr/pull/3300#discussion_r2023738100
##########
solr/core/src/test/org/apache/solr/cli/ZkSubcommandsTest.java:
##########
@@ -406,45 +407,35 @@ public void testUpConfigLinkConfigClearZk() throws
Exception {
assertEquals("Comparing downloaded files to what is in ZK",
files.size(), zkFiles.size());
}
- Path sourceConfDir = ExternalPaths.TECHPRODUCTS_CONFIGSET;
- // filter out all directories starting with . (e.g. .svn)
- try (Stream<Path> stream = Files.walk(sourceConfDir)) {
- List<Path> files =
- stream
- .filter(Files::isRegularFile)
- .filter(path -> path.getFileName().startsWith("."))
Review Comment:
Thanks for fixing this test. I need to be more mindful when modifying a
block this big. I agree startsWith is very confusing with path for migration
and the same issue was ran into in another part of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
