HoustonPutman commented on code in PR #2960:
URL: https://github.com/apache/solr/pull/2960#discussion_r2021345672
##########
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##########
@@ -1976,7 +1975,10 @@ public ScoreMode scoreMode() {
MultiThreadedSearcher.TopDocsResult topDocsResult =
searchResult.getTopDocsResult();
totalHits = topDocsResult.totalHits;
topDocs = topDocsResult.topDocs;
-
+ if (searchResult.isTerminatedEarly) {
Review Comment:
So `searchResult.isTerminatedEarly` could have been set to `true` because
maxShardHits had been reached right? If so, shouldn't this be setting
`setMaxHitsTerminatedEarly` to true?
Honestly, shouldn't `searchResult` be using `isMaxHitsTerminatedEarly` not
`isTerminatedEarly`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
