janhoy commented on code in PR #3291:
URL: https://github.com/apache/solr/pull/3291#discussion_r2018513810
##########
solr/core/src/java/org/apache/solr/cli/SolrProcessManager.java:
##########
@@ -162,42 +169,60 @@ private static Optional<String> commandLine(ProcessHandle
ph) {
if (!Constants.WINDOWS) {
return ph.info().commandLine();
} else {
- long desiredProcessid = ph.pid();
- try {
- Process process =
- new ProcessBuilder(
- "wmic",
- "process",
- "where",
- "ProcessID=" + desiredProcessid,
- "get",
- "commandline",
- "/format:list")
- .redirectErrorStream(true)
- .start();
- try (InputStreamReader inputStreamReader =
- new InputStreamReader(process.getInputStream(),
StandardCharsets.UTF_8);
- BufferedReader reader = new BufferedReader(inputStreamReader)) {
- while (true) {
- String line = reader.readLine();
- if (line == null) {
- return Optional.empty();
- }
- if (!line.startsWith("CommandLine=")) {
- continue;
- }
- return Optional.of(line.substring("CommandLine=".length()));
- }
- }
- } catch (IOException e) {
+ return Optional.ofNullable(pidToWindowsCommandLineMap.get(ph.pid()));
+ }
+ }
+
+ /**
+ * Gets the command lines of all java processes on Windows using PowerShell.
+ *
+ * @return a map of process IDs to command lines
+ */
+ private static Map<Long, String> commandLinesWindows() {
+ try {
+ Process process =
+ new ProcessBuilder(
+ "powershell.exe",
+ "-Command",
+ "Get-CimInstance -ClassName Win32_Process | Where-Object {
$_.Name -like '*java*' } | Select-Object ProcessId, CommandLine |
ConvertTo-Json -Depth 1")
Review Comment:
The `Get-CimInstance` is not available in Powershell 2.0 (Windows 7). We
could use `Get-WmiObject` instead, but it is slower. Don't think we need to
care too much about Windows 7 these days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
