David Smiley created SOLR-17712:
-----------------------------------

             Summary: SolrCloud: remove CommonAdminParams.waitForFinalState; 
default to TRUE
                 Key: SOLR-17712
                 URL: https://issues.apache.org/jira/browse/SOLR-17712
             Project: Solr
          Issue Type: Improvement
          Components: SolrCloud
            Reporter: David Smiley


Collection creation has an optional parameter 
[waitForFinalState|https://solr.apache.org/guide/solr/latest/deployment-guide/collection-management.html#create]
 :
{quote}If {{{}true{}}}, the request will complete only when all affected 
replicas become active. The default is {{{}false{}}}, which means that the API 
will return the status of the single action, which may be before the new 
replica is online and active.{quote}
Wouldn’t a caller of a command (any command to anything; whatever) generally 
expect that the command has completed when a command returns?  I question the 
default choice of this parameter.  I believe it pre-dated the more general 
“async” support of collection commands.
 
Proposal: remove it.  Internal logic should behave as if it's "true".
 
Come to think of it, I see this in quite a number of other commands involving 
replica creations too.
First baby step (individual PR) might simply be to change the default and wait 
some weeks through tests.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to