hossman commented on PR #3280: URL: https://github.com/apache/solr/pull/3280#issuecomment-2741397852
i don't know enough python to give feedback on the script, but i have to wonder if "copy all the cdn for each ref-guide version" is really the best approach? i'm pretty sure many version of the ref-guide re-use the same versions of external css/js files - so why not just have a single, shared, top level `/old_cdn/` directory where we mirror anything we previously got from a remote host? ``` https://cdnjs.cloudflare.com/ajax/libs/jquery/2.1.4/jquery.min.js -> https://solr.apache.org/old_cdn/cdnjs.cloudflare.com/ajax/libs/jquery/2.1.4/jquery.min.js https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/js/bootstrap.min.js -> https://solr.apache.org/old_cdn/maxcdn.bootstrapcdn.com/bootstrap/3.3.7/js/bootstrap.min.js ... ``` That way we minimize the number of duplicate files, and the modifications to our html files in each ref guide are just replacing any external css/js links ala `s/http(s?):\/\/(.*)/\/old_cdn\/$2/` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
