[
https://issues.apache.org/jira/browse/SOLR-17706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938283#comment-17938283
]
Houston Putman commented on SOLR-17706:
---------------------------------------
{{TestDocumentObjectBinder.testChild}} has started to fail occasionally after
this commit:
[http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.client.solrj.beans.TestDocumentObjectBinder.testChild]
[https://ci-builds.apache.org/job/Solr/job/Solr-Test-main/9879/testReport/junit/org.apache.solr.client.solrj.beans/TestDocumentObjectBinder/testChild/]
> Make DocumentObjectBinder a static singleton
> --------------------------------------------
>
> Key: SOLR-17706
> URL: https://issues.apache.org/jira/browse/SOLR-17706
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Labels: pull-request-available
> Fix For: main (10.0)
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> SolrJ's DocumentObjectBinder maps custom objects to solr docs, either way.
> It reads info about classes via reflection and stores it into a field. I see
> no reason why this shouldn't be a global singleton since it's basically class
> metadata; its contents should be stable. Today there's an instance of it on
> SolrClient and it has quirky use in QueryResponse. I could see how this
> makes it possible to customize it by a user but there are other ways to do
> this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
