uschindler commented on code in PR #3285:
URL: https://github.com/apache/solr/pull/3285#discussion_r2010612297
##########
solr/modules/cross-dc/build.gradle:
##########
@@ -24,7 +24,7 @@ description = 'Cross-DC Replication Plugins'
ext {
// Use of the security manager is not supported on windows.
// Mockito does not work with it enabled.
- useSecurityManager = !Os.isFamily(Os.FAMILY_WINDOWS)
+ useSecurityManager = rootProject.ext.runtimeJavaVersion <=
JavaVersion.VERSION_23 && !Os.isFamily(Os.FAMILY_WINDOWS)
Review Comment:
this is basically an addition which was used only in this module, which
overrides the setting in base task defintion.
Maybe change this to use `useSecurityManager &=
!Os.isFamily(Os.FAMILY_WINDOWS)`
This would take the setting from top-level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
