dsmiley commented on code in PR #3272:
URL: https://github.com/apache/solr/pull/3272#discussion_r2006318172
##########
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java:
##########
@@ -140,7 +140,7 @@ public FileVisitResult postVisitDirectory(Path dir,
IOException ioException)
}
@Override
- protected void uploadConfig(String configName, Path source) throws
IOException {
+ public void uploadConfig(String configName, Path source) throws IOException {
Review Comment:
why?
##########
solr/core/src/test/org/apache/solr/cloud/MockScriptUpdateProcessorFactory.java:
##########
@@ -38,15 +36,7 @@ public class MockScriptUpdateProcessorFactory extends
UpdateRequestProcessorFact
implements SolrCoreAware {
@Override
- public void inform(SolrCore core) {
- if (!core.getCoreDescriptor().isConfigSetTrusted()) {
- throw new SolrException(
- ErrorCode.UNAUTHORIZED,
- "The configset for this collection was uploaded without any
authentication in place,"
- + " and this operation is not available for collections with
untrusted configsets. To use this component, re-upload the configset"
- + " after enabling authentication and authorization.");
- }
- }
+ public void inform(SolrCore core) {}
Review Comment:
stop implementing SolrCoreAware here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
