[
https://issues.apache.org/jira/browse/SOLR-17682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937200#comment-17937200
]
ASF subversion and git services commented on SOLR-17682:
--------------------------------------------------------
Commit 7bf7379d6c75f4ad4486e4f533bdac971a7749a5 in solr's branch
refs/heads/main from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=7bf7379d6c7 ]
SOLR-17682: Rename BinaryResponseWriter to JavaBinResponseWriter (#3267)
> Refactor QueryResponseWriter hierarchy to put binary at the base and add
> TextQueryResponseWriter sub
> ----------------------------------------------------------------------------------------------------
>
> Key: SOLR-17682
> URL: https://issues.apache.org/jira/browse/SOLR-17682
> Project: Solr
> Issue Type: Improvement
> Reporter: David Smiley
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The QueryResponseWriter hierarchy should be inverted. Instead of Writer/Text
> being at the base with a subclass (BinaryResponseWriter) doing
> OutputStream/Binary, it should be inverted. QueryResponseWriter should have
> write(OutputStream,...) and there should be a subclass/interface
> TextResponseWriter for the textual formats. Once this is done, there are
> some awkward methods that do casting (a code smell) that will instead be
> simplified. There will be no use for QueryResponseWriterUtil. This is all
> best shown in a PR to see why it's better.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
