smoldenhauer-ish commented on code in PR #712:
URL: https://github.com/apache/solr-operator/pull/712#discussion_r2003318083
##########
controllers/solr_cluster_ops_util.go:
##########
@@ -150,6 +152,60 @@ func retryNextQueuedClusterOpWithQueue(statefulSet
*appsv1.StatefulSet, clusterO
return hasOp, err
}
+func determinePvcExpansionClusterOpLockIfNecessary(instance
*solrv1beta1.SolrCloud, statefulSet *appsv1.StatefulSet) (clusterOp
*SolrClusterOp, retryLaterDuration time.Duration, err error) {
+ if instance.Spec.StorageOptions.PersistentStorage != nil &&
+
instance.Spec.StorageOptions.PersistentStorage.PersistentVolumeClaimTemplate.Spec.Resources.Requests.Storage()
!= nil &&
+
instance.Spec.StorageOptions.PersistentStorage.PersistentVolumeClaimTemplate.Spec.Resources.Requests.Storage().String()
!= statefulSet.Annotations[util.StorageMinimumSizeAnnotation] {
+ // First make sure that the new Storage request is greater than
what already is set.
+ // PVCs cannot be shrunk
+ newSize :=
instance.Spec.StorageOptions.PersistentStorage.PersistentVolumeClaimTemplate.Spec.Resources.Requests.Storage()
+ // If there is no old size to update, the StatefulSet can be
just set to use the new PVC size without any issue.
+ // Only do a cluster operation if we are expanding from an
existing size to a new size
+ if oldSizeStr, hasOldSize :=
statefulSet.Annotations[util.StorageMinimumSizeAnnotation]; hasOldSize {
+ if oldSize, e := resource.ParseQuantity(oldSizeStr); e
!= nil {
+ err = e
+ // TODO: add an event
+ } else {
+ // Only update to the new size if it is bigger,
we cannot shrink PVCs
+ if newSize.Cmp(oldSize) > 0 {
+ clusterOp = &SolrClusterOp{
+ Operation: PvcExpansionLock,
+ Metadata: newSize.String(),
+ }
+ }
+ // TODO: add an event saying that we cannot
shrink PVCs
+ }
+ }
+ }
+ return
+}
+
+// handleManagedCloudScaleUp does the logic of a managed and "locked" cloud
scale up operation.
+// This will likely take many reconcile loops to complete, as it is moving
replicas to the pods that have recently been scaled up.
Review Comment:
```suggestion
// handlePvcExpansion handles the logic of a persistent volume claim
expansion operation.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
