psalagnac opened a new pull request, #3258: URL: https://github.com/apache/solr/pull/3258
https://issues.apache.org/jira/browse/SOLR-17651 # Description End goal is to make sure unit tests for CLI tools never make a call to `System.exit()`. This introduces class `ToolRuntime` which is initiated and passed as a context for all CLI tools. When running tests, a sub-classes is used instead and blocks calls to `System.exit()`. For now, I did only the minimal (large enough!) change to intercept calls to `System.exit()`. The newly introduced `ToolRuntime` may be leveraged later to remove some static calls, I'm mostly thinking about IOs which are pretty messy for now. We could improve testability by always using the runtime context for outputs. # Tests `BasicAuthIntegrationTest` was invoking `System.exit()`, which causes a very long timeout when running with Gradle. I figured out this test was doing what it should (will comment inline). I added `StatusToolTest` to keep same coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
