epugh commented on PR #3223:
URL: https://github.com/apache/solr/pull/3223#issuecomment-2714863862
> So instead of using SOLR_TOOL_HOST, and instead using SOLR_HOST in the
java code, I think we can remove the SOLR_TOOL_HOST all together, since we set
it in `bin/solr`:
>
> ```shell
> SOLR_TOOL_HOST="${SOLR_HOST:-localhost}"
> export SOLR_TOOL_HOST
> ```
>
> So since we are already defaulting to `localhost` in the code, I think we
can remove `SOLR_TOOL_HOST` altogether and change `String host =
EnvUtils.getProperty("solr.tool.host", "localhost");` to `String host =
EnvUtils.getProperty("solr.host", "localhost");` in `CLIUtils`
>
> But I agree that unfortunately the AUTH_PORT is a backwards incompatible
change. Maybe instead we still check for the `auth` command in the 9.x code and
do `export SOLR_PORT="${AUTH_PORT}"`. And we can keep the code to get that port
the same. But in 10, we can remove it and the additional export.
Got a green on the scripts, so now looking at the AUTH_PORT. So, I am
thinking we on this PR do the check for AUTH_PORT and do what you suggested.
Commit and backport that. And then in a NEW PR strip out the export
SOLR_PORT="${AUTH_PORT}"` that only goes on main?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
