janhoy commented on code in PR #3217:
URL: https://github.com/apache/solr/pull/3217#discussion_r1971625911
##########
solr/solr-ref-guide/ui-src/partials/head-icons.hbs:
##########
@@ -1,3 +1,20 @@
<!-- Solr Changes - Start -->
<link rel="icon" href="{{{uiRootPath}}}/img/favicon.ico"
type="image/x-icon">
+ {{#if env.MATOMO_ENABLED}}
+ <script>
Review Comment:
I piggy-backed on `head-icons.hbs` instead of customizing `head.hbs`. See
https://gitlab.com/antora/antora-ui-default/-/blob/master/src/partials/head.hbs
for the default template. I could of course fork `head.hbs`, add a new
`head-matomo.hbs` to the end to separate it more. But the `head-icons` script
is already the last in <head> and already customized, so an easier choice. I
can be persuaded otherwise though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
