gerlowskija commented on code in PR #3190:
URL: https://github.com/apache/solr/pull/3190#discussion_r1971457633
##########
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##########
@@ -409,23 +409,27 @@ private static void printHelp() {
print(
" healthcheck, create, delete, auth,
assert, config, export, api, package, post, stream,");
print(
- " zk ls, zk cp, zk rm , zk mv, zk
mkroot, zk upconfig, zk downconfig,");
+ " zk ls, zk cp, zk rm , zk mvStandalone
server example, zk mkroot, zk upconfig, zk downconfig,");
Review Comment:
[-1] What is "Standalone server example" doing in this list of `bin/solr`
subcommands?
##########
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##########
@@ -409,23 +409,27 @@ private static void printHelp() {
print(
" healthcheck, create, delete, auth,
assert, config, export, api, package, post, stream,");
print(
- " zk ls, zk cp, zk rm , zk mv, zk
mkroot, zk upconfig, zk downconfig,");
+ " zk ls, zk cp, zk rm , zk mvStandalone
server example, zk mkroot, zk upconfig, zk downconfig,");
print(
" snapshot-create, snapshot-list,
snapshot-delete, snapshot-export, snapshot-prepare-export");
print("");
- print(" Standalone server example (start Solr running in the background
on port 8984):");
+ print(" Start Solr running in the background on port 8984:");
Review Comment:
[0] IMO the lead-in to this example should make some reference either to the
"mode" or the ZK that will be used. Especially since this behavior changed in
Solr 10, a user coming from Solr 9 could read this snippet and be
none-the-wiser that they're about to run SolrCloud.
Also, is the "in the background" bit worth retaining?
Perhaps:
> Start Solr with its own "embedded" ZooKeeper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
