dsmiley opened a new pull request, #3207: URL: https://github.com/apache/solr/pull/3207
While working on something nearby, I noticed that `JavaBinUpdateRequestCodec.readOuterMostDocIterator` (server side, processes an update request that's JavaBin formatted) reads the outer most object checking for a variety of possibilities. I'm suspicious of them so added some asserts and found out when some were added. https://issues.apache.org/jira/browse/SOLR-2904 weird https://issues.apache.org/jira/browse/SOLR-13731 this one is actually tested but not realistically to how users use javabin. Even if we just end up leaving some comments, it'd be helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org