[ 
https://issues.apache.org/jira/browse/SOLR-17663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17926700#comment-17926700
 ] 

ASF subversion and git services commented on SOLR-17663:
--------------------------------------------------------

Commit 933abef4dbe137343e196818b8d16653d70c0667 in solr's branch 
refs/heads/branch_9x from Bruno Roustant
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=933abef4dbe ]

SOLR-17663: Protect TimeOut from overflow. (#3173)



> TimeOut overflows if the provided interval is large
> ---------------------------------------------------
>
>                 Key: SOLR-17663
>                 URL: https://issues.apache.org/jira/browse/SOLR-17663
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 9.8
>            Reporter: Bruno Roustant
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> TimeOut constructor is passed a long interval parameter. If this long is 
> large enough, the timeoutAt field overflows, making all the methods 
> incorrect, including hasTimedOut() which returns true immediately.
> TimeUnit.convert() deals with the same problem by checking the value to 
> convert ahead of time and by setting fixed Long.MAX_VALUE to prevent 
> overflow. We should do the same for timeoutAt in TimeOut constructor.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to