dsmiley commented on code in PR #3153:
URL: https://github.com/apache/solr/pull/3153#discussion_r1949516798
##########
build.gradle:
##########
@@ -35,6 +35,8 @@ plugins {
}
// Declare default Java versions for the entire project and for SolrJ
separately
+rootProject.ext.currentJavaVersion = JavaVersion.current()
+rootProject.ext.minJavaVersionSolrJ =
JavaVersion.toVersion(libs.versions.java.solrj.get())
Review Comment:
duplicates line 41
##########
gradle/testing/randomization.gradle:
##########
@@ -204,6 +204,10 @@ allprojects {
if (project.ext.has("useSecurityManager")) {
useSecurityManager = project.ext.get("useSecurityManager")
}
+ // Solr does not run with the Security Mangager for Java 24+
Review Comment:
```suggestion
// There is no longer a Security Manager in Java 24
```
##########
solr/bin/solr:
##########
@@ -1155,6 +1155,11 @@ else
REMOTE_JMX_OPTS=()
fi
+# Do not use the java security manager when running Java 24+
+if (( JAVA_VER_NUM >= 24 )) ; then
Review Comment:
could just combine this condition into line 1164. Ideally this changes the
"true" in the default interpretation of that env var to a "false". But it's
fine.
##########
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc:
##########
@@ -67,6 +67,10 @@ It is always strongly recommended that you fully reindex
your documents after a
In Solr 8, it was possible to add docValues to a schema without re-indexing
via `UninvertDocValuesMergePolicy`, an advanced/expert utility.
Due to changes in Lucene 9, that isn't possible any more.
+== Solr 9.9
+=== Java Security Manager
+Java removed support for the Security Manager starting with Java 24, therefore
Solr will disable the feature when run with Java 24 or later.
+
Review Comment:
minor: Okay but arguably you didn't have to bother to say this. There's no
action for the user to take. I don't think it's up to Solr to tell people
what's coming/going/happening in the Java ecosystem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
