malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1947559396
########## gradle/libs.versions.toml: ########## @@ -0,0 +1,65 @@ +[versions] Review Comment: I have looked into the way we generate and check the existing checksums, and I noticed that, because this module is a kotlin multiplatform module, it does not have the same configuration names used in the jar validation task (which are `runtimeClasspath`, `compileClasspath`, `testRuntimeClasspath`, `testCompileClasspath`). Therefore, no checksums or license checks are executed on this module yet. I have created [SOLR-17657](https://issues.apache.org/jira/browse/SOLR-17657) for a potentially more robust way of generating checksums and also add signature verification. The proposed changes would also cover the new multiplatform module, as well as configurations from plugins and other places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
