dsmiley commented on code in PR #3144:
URL: https://github.com/apache/solr/pull/3144#discussion_r1938342390
##########
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java:
##########
@@ -1485,7 +1486,8 @@ private Long readIntervalMs(String interval) {
return TimeUnit.MILLISECONDS.convert(readIntervalNs(interval),
TimeUnit.NANOSECONDS);
}
- private Long readIntervalNs(String interval) {
+ @VisibleForTesting
+ public static Long readIntervalNs(String interval) {
Review Comment:
indeed; it explains why it's more open than it otherwise needs to be
##########
solr/core/src/test/org/apache/solr/cloud/ReplicateFromLeaderTest.java:
##########
@@ -18,54 +18,105 @@
package org.apache.solr.cloud;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertThrows;
+import org.apache.solr.common.SolrException;
import org.apache.solr.core.SolrConfig;
+import org.junit.After;
+import org.junit.Before;
import org.junit.Test;
public class ReplicateFromLeaderTest {
+ private String jettyTestMode;
+
+ @Before
+ public void setUp() {
Review Comment:
Indeed we do. Firstly, all Solr tests ought to extend SolrTestCase, at
least indirectly. This test doesn't; it should be modified. Secondly, STCJ4
includes:
```aiignore
@Rule public TestRule solrTestRules = RuleChain.outerRule(new
SystemPropertiesRestoreRule());
```
That obsoletes the setup & tearDown here.
So for now, I suggest removing the setup & teardown here and subclass STCJ4.
It's a TODO for me in my work on making SolrTestCase a better base class to
transition that line from STCJ4 to STC.
##########
solr/solr-ref-guide/modules/configuration-guide/pages/commits-transaction-logs.adoc:
##########
@@ -62,6 +62,8 @@ It is recommended that this be set for as long as is
reasonable given the applic
A hard commit means that, if a server crashes, Solr will know exactly where
your data was stored; a soft commit means that the data is stored, but the
location information isn't yet stored.
The tradeoff is that a soft commit gives you faster visibility because it's
not waiting for background merges to finish.
+In a TLOG/PULL replica setup, the commit configuration also influences the
interval at which the replica is polling the shard leader. You may optionally
configure a custom `commitPollInterval`.
Review Comment:
Please start new sentences on new lines. Not sure if this style choice is
stated somewhere. Goal is reducing diffs and reducing need for line wrap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
