gerlowskija opened a new pull request, #3047: URL: https://github.com/apache/solr/pull/3047
https://issues.apache.org/jira/browse/SOLR-17351 # Description Solr's filestore "get file" API actually covers 4 or 5 distinct operations. Depending on provided query parameters, it can: - return filestore entry metadata (when meta=true is specified) - instruct the receiving Solr node to pull a file from another node's filestore and cache it locally (when getFrom=someOtherNode is specified) - instruct the receiving Solr node to push its cached copy of a file out to all other Solr nodes (when sync=true is specified) - return raw file contents - return JSON-ified file contents This makes the code for this endpoint somewhat complex. It also makes it hard to model and parse the response on the client side. # Solution This PR splits up the "get file" endpoint into a number of different APIs. Specifically: - metadata-fetching has been moved out to the endpoint, `GET/api/cluster/filestore/metadata/some/path.txt` - Filestore commands such as pushing/pulling files are now available at: ` POST /api/cluster/filestore/commands` - Support for "JSON-ified" file data has been dropped in this PR (but will be retained but deprecated in the eventual 9.x backport) These divisions allow us to generate SolrRequest/SolrResponse classes representing these APIs, meaning that SolrJ users no longer need to use GenericSolrRequest/GenericSolrResponse. # Tests Some rewriting in TestDistribFileStore. Existing package and filestore tests continue to pass. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
