gerlowskija commented on code in PR #3032:
URL: https://github.com/apache/solr/pull/3032#discussion_r1920929167
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/InputStreamResponseParser.java:
##########
@@ -21,9 +21,16 @@
import org.apache.solr.client.solrj.ResponseParser;
import org.apache.solr.common.util.NamedList;
-/** Simply puts the InputStream into an entry in a NamedList named "stream". */
+/**
+ * Simply puts the InputStream into an entry in a NamedList named "stream".
+ *
+ * @see org.apache.solr.client.solrj.InputStreamResponse
+ */
public class InputStreamResponseParser extends ResponseParser {
+ public static String STREAM_KEY = "stream";
+ public static String HTTP_STATUS_KEY = "responseStatus";
Review Comment:
I agree that "httpStatus" is much better name-wise, but changing the name of
the key would break any SolrJ users that make use of InputStreamResponseParser.
We could tweak the 9.x backport of this PR to make the status-code available
under both 'responseStatus' and 'httpStatus' (and "deprecate" the former). But
that gets pretty far afield from the main goal of this PR, so I might skip it
for reasons of scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
