gerlowskija commented on PR #2930: URL: https://github.com/apache/solr/pull/2930#issuecomment-2592840832
> Worth some digging there to see what the original intention was, and whether it's worth maintaining both options (at least in terms of the arbitrary/user-specified "modify" properties). The history here is actually kindof interesting. "modify collection" was added back in 6.0, but didn't initially support arbitrary properties. Arbitrary props were added later, and kindof by accident. SOLR-13271 added the "readOnly" property, and the first draft of that functionality added "readOnly" using the syntax that we now call arbitrary/user-provided. The patch later pivoted to handling "readOnly" as a first-class property, similarly to replicationFactor, collection.configName, etc, but the plumbing for "user-provided" props was never removed. Collection properties (added by SOLR-11960) had existed for around a year at this time, but they weren't used very widely, and never came up in the SOLR-13271 discussion. Given all this, I suspect the duplication was accidental oversight and not an intentional choice. Going to ping SOLR-13271 to confirm this, and if so maybe we could deprecate the arbitrary-props in modify-collection in favor of COLLECTIONPROPs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
