dsmiley commented on code in PR #3030: URL: https://github.com/apache/solr/pull/3030#discussion_r1914031744
########## gradle/maven/defaults-maven.gradle: ########## Review Comment: The only real change in this file is limiting the `gradle.projectsEvaluated` section to only the `signing` section, which is now the only part that needs to be evaluated later, since it depends on extensions in the distribution module. ########## gradle/ant-compat/misc.gradle: ########## @@ -1,24 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - - -// Exclude inner classes from testing. -allprojects { - tasks.withType(Test) { task -> - exclude '**/*$*' Review Comment: if the test run fails for running inner classes as tests then I'll add this simple exclude line to a suitable other gradle file. It's not deserving of a dedicated gradle script! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
