gerlowskija commented on code in PR #738:
URL: https://github.com/apache/solr-operator/pull/738#discussion_r1904249289


##########
docs/development.md:
##########
@@ -55,6 +55,11 @@ export PATH="$PATH:$GOPATH/bin" # You likely want to add 
this line to your ~/.ba
 make install-dependencies
 ```
 
+Note: if you have previously installed/older versions of dependencies, you can 
first clear these dependencies with:

Review Comment:
   [+1] Thanks for this clarification!



##########
tests/e2e/test_utils_test.go:
##########
@@ -581,6 +581,91 @@ func generateBaseSolrCloud(replicas int) 
*solrv1beta1.SolrCloud {
        }
 }
 
+func generateSolrSecuritySecret(ctx context.Context, solrCloud 
*solrv1beta1.SolrCloud) {
+       securityJsonSecret := &corev1.Secret{
+               ObjectMeta: metav1.ObjectMeta{
+                       Name:      solrCloud.Name + "-security-secret",
+                       Namespace: solrCloud.Namespace,
+               },
+               StringData: map[string]string{
+                       "security.json": `{
+                               "authentication": {
+                               "blockUnknown": false,
+                               "class": "solr.BasicAuthPlugin",
+                               "credentials": {
+                                       "test-oper": 
"IV0EHq1OnNrj6gvRCwvFwTrZ1+z1oBbnQdiVC3otuq0= 
Ndd7LKvVBAaZIF0QAVi1ekCfAJXr1GGfLtRUXhgrF8c="

Review Comment:
   [0] Might be worth a short comment describing how to regenerate this JSON 
(and particularly this credential hash), so that readers know how to tweak or 
adapt it if there's ever a need going forward.
   
   Also - I'm assuming the password is 'SolrRocks', but it might be worth being 
explicit about that in case folks debugging a failure want to make their own 
requests to the cluster.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to