gerlowskija opened a new pull request, #2930: URL: https://github.com/apache/solr/pull/2930
https://issues.apache.org/jira/browse/SOLR-16391 # Description Solr's v2 API supports a "modify-collection" API, but its implementation uses the legacy (non JAX-RS) framework. # Solution This PR migrates the "modify-collection" API to a JAX-RS implementation. This ensures that the APIs are covered by our v2 API OAS, and includes them in all code-generation done using the OAS. It also makes slight tweaks to the appearance of the API to help it fit in a bit more with the current API design. In particular: - `PUT` is now used as the HTTP verb, - the "command" property (i.e. "modify") and additional request body nesting have been removed. - an "unset" property has been added to the request body (see comment below). # Tests Updates to V2CollectionsAPIMappingTest. Tweaks to various other "modify coll" related tests. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
