alessandrobenedetti commented on PR #2809: URL: https://github.com/apache/solr/pull/2809#issuecomment-2546104588
So, I spent a bit more time and ended up: 1) accepting upstream locks 2) running locally: ./gradlew writeLocks 3) committing the diff Which is still huge and I have no idea if it makes sense or not, nor I know any verification I can do, I hope I can get some feedback decently soon, if not in case I see green tests I'll proceed anyway, but it's not ideal and I wonder if we want this to be this way Disclaimer: I know very little about dep management in Solr, but it seems suspicious that for such a minor dependency change (introduced in a module 4-5 libs) you end up needing to evaluate such a big diff? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
