[ https://issues.apache.org/jira/browse/SOLR-17583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905070#comment-17905070 ]
Jan Høydahl commented on SOLR-17583: ------------------------------------ Thanks for the attention to this, and for taking the time to backport. PS: If you experienced any difficulties during the contribution process, feel free to drop a note so we can improve in that area too. > Bring back documentation for Adding Custom Expressions > ------------------------------------------------------ > > Key: SOLR-17583 > URL: https://issues.apache.org/jira/browse/SOLR-17583 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: documentation > Affects Versions: 9.7 > Reporter: cfeldmann > Assignee: Jan Høydahl > Priority: Major > Labels: newdev, pull-request-available > Fix For: 9.7, 9.8 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > A change was pushed to do a major revision of the Streaming Expressions guide > almost 4 years ago in version 8.8: SOLR-13105 A visual guide to Solr Math > Expressions and Streaming Expressions > > In this change, the following section was removed: > > {quote}Adding Custom Expressions > Creating your own custom expressions can be easily done by implementing the > [Expressible|https://lucene.apache.org/solr/8_5_0/solr-solrj/org/apache/solr/client/solrj/io/stream/expr/Expressible.html] > interface. To add a custom expression to the list of known mappings for the > /stream and /graph handlers, you just need to declare it as a plugin in > solrconfig.xml via: > <expressible name="custom" class="org.example.CustomStreamingExpression"/> > {quote} > > There was no mention of deprecating the feature or removing this section. > Given the massive size of the diff, it looks to be an inadvertent removal. > > The feature works. There’s no deprecation of this feature mentioned in any > of the Solr docs since it was removed from the guide without explanation. > The code itself is not deprecated. > > The Config API doc still includes > add-expressible/update-expressible/delete-expressible > > Since the feature still works, has not been deprecated and seems to have been > accidently removed from the documentation, let's bring this section back. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org