risdenk commented on PR #2835: URL: https://github.com/apache/solr/pull/2835#issuecomment-2509521831
I think there might be a few more places to cleanup based on running the following on your branch ``` git grep -nFi kerber | grep -Fv -e 'solr/modules/hdfs' -e 'solr-on-hdfs.adoc' -e 'solr/CHANGES.txt' -e 'solr/benchmark/src/resources/words.txt' ``` Specifically these findings: ``` solr/bin/solr.in.sh:296:# Solr internally doesn't use cookies other than for modules such as Kerberos/Hadoop Auth. If you don't need any of those solr/core/src/java/org/apache/solr/cli/AuthTool.java:124: + " bin/solr auth enable --type kerberos --config \\\"<kerberos configs>\\\" [--update-include-file-only <true|false>] [-v]\n" solr/core/src/java/org/apache/solr/core/CoreContainer.java:602: // this caused plugins like KerberosPlugin to register its intercepts, but this intercept solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java:328: // obviously don't care. Kerberos plugins seem to mostly use it to satisfy the api of a solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java:351: // if it should short circuit, e.g. the Kerberos Authentication Filter will send an error and solr/webapp/web/js/angular/controllers/index.js:27: // Needed for Kerberos, since this is the only place from where solr/webapp/web/js/angular/controllers/index.js:28: // Kerberos username can be obtained. ``` It would be awesome to be able to cleanup the security policy files but I know there is some overlap with the Hadoop hdfs tests too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
