pjmcarthur opened a new pull request, #2871: URL: https://github.com/apache/solr/pull/2871
Remove code in Assign.java that was required for compatibility with collections created before 7.0 https://issues.apache.org/jira/browse/SOLR-XXXXX <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description This PR removes code that was used to allow upgrades from 6.x to 7.0 to work with existing collections. It simplifies the code, making it easier to maintain. # Solution When generating a name for a new Core, Assign uses an atomic integer that is kept at the collection root in ZooKeeper. For new Collections created in 7.0 and later, this counter is always initialized to 0, and atomically incremented each time a new Core for that Collection is created. With Collections that already existed before upgrading to 7.0, it was necessary to initialize this counter to a higher value in an attempt to make it unique. This created a lot of complexity, and given that we are now on 10.x, this code should be removed. # Tests AssignBackwardCompatibilityTest has been removed # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
