gerlowskija commented on PR #2734:
URL: https://github.com/apache/solr/pull/2734#issuecomment-2468162712
> Hey @gerlowskija made the changes but ended up kind of inflating this PR
to support the OpenAPI code generation and moving files
Awesome! I see a lot of the increase comes from moving some of the other
replication APIs ("list files", "get index version") from core over to the
"api" module -- I've actually got another PR that takes a stab at some of those
changes as well, so if we rebase one on top of the other, that should shrink
this PR back down a good bit. Will take a crack at that shortly, and check
back in when that's done!
Very curious about the "StreamingOutput" type you found. I've used
`InputStream` in a few similar cases with other APIs (e.g. there's a
"filestore" API that returns raw files, similar to this /replication one),
though maybe StreamingOutput is better? Will have to do some reading...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
