[
https://issues.apache.org/jira/browse/SOLR-17483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896902#comment-17896902
]
ASF subversion and git services commented on SOLR-17483:
--------------------------------------------------------
Commit 9023e70ff72e4a2b08277469e980b4ed7bc2cd56 in solr's branch
refs/heads/branch_9x from Christos Malliaridis
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=9023e70ff72 ]
SOLR-17483: Backport cleanup zk-related logic in bin/solr.cmd (#2823)
* SOLR-17484: Cleanup zk-related logic in bin/solr.cmd (#2816)
* Remove ZK logic from solr.cmd as it is obsolete
* Fix unreachable auth tool in solr.cmd
* Fix invalid references
(cherry picked from commit c2091d0258400c9064b8c67fe0d974e367ecccfd)
* Fix exec issue when executing bin\solr.cmd start
The closing parentheses caused the IF to be closed before
the echo message was fully printed, leading to "mode."
being executed instead of printed.
> bin/solr.cmd run_zk method can be drastically simplified
> --------------------------------------------------------
>
> Key: SOLR-17483
> URL: https://issues.apache.org/jira/browse/SOLR-17483
> Project: Solr
> Issue Type: Sub-task
> Components: cli
> Affects Versions: 9.8
> Reporter: Eric Pugh
> Assignee: Christos Malliaridis
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> In the bin/solr.cmd windows script, the :run_zk method still has all the
> logic for validating arguments. However, we can now rely on the java code
> for that.
> I suspect there are other opportunities for shrinking bin/solr.cmd as well
> now that argument parsing/handling is in Java.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
