[
https://issues.apache.org/jira/browse/SOLR-17485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894048#comment-17894048
]
ASF subversion and git services commented on SOLR-17485:
--------------------------------------------------------
Commit 8f18729f97e897f3755421c65b4b539fbc871746 in solr's branch
refs/heads/main from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=8f18729f97e ]
SOLR-17485 Remove CheckLoggingConfiguration; unnecessary (#2763)
A refactoring, and removing needless CheckLoggingConfiguration.
Misc changes:
* Extend HttpFilter etc.; remove needless subclasses. Thus don't need to cast
HttpServletRequest.
* remove no-op needless destroy(); same as super
* Move excludePath check to very first thing
* rename doFilter(...retry) to doFilterRetry
* move closeShield to before doFilterRetry so it doesn't have to know about
retry, simplifying things.
* no longer have leading underscore param names since no longer have variable
masking
> Remove Slf4j ClassNotFoundException avoidance checks
> ----------------------------------------------------
>
> Key: SOLR-17485
> URL: https://issues.apache.org/jira/browse/SOLR-17485
> Project: Solr
> Issue Type: Improvement
> Reporter: David Smiley
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> If a user removes logging libs from lib/ext, they are on their own, more or
> less. CheckLoggingConfiguration (SOLR-5951) tries to detect an early
> ClassNotFoundException and prints a more helpful error. IMO we're doing too
> much; a CNFE is clear enough, and furthermore Slf4j will print an explicit
> ERROR as well right before (what happens if we remove it; I tried). I
> suspect it came out when Solr still supported a WAR or maybe was less clear
> what the error was back then. And I suspect it hasn't worked since we added
> a ServletContextListener for CoreContainerProvider. While it could be
> remedied, I'd rather remove the old code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
