malliaridis commented on code in PR #2807:
URL: https://github.com/apache/solr/pull/2807#discussion_r1820588287
##########
solr/solr-ref-guide/modules/deployment-guide/pages/solr-control-script-reference.adoc:
##########
@@ -1634,16 +1634,27 @@ NOTE: The `export` command only works with in a Solr
running in cloud mode.
The `bin/solr export` command takes the following parameters:
-`--url <url>`::
+`--solr-url <url>`::
+
[%autowidth,frame=none]
|===
s|Required |Default: none
Review Comment:
Is the default `none` or the local host for `--solr-url`?
##########
solr/core/src/java/org/apache/solr/cli/ExportTool.java:
##########
@@ -116,28 +116,48 @@ public List<Option> getOptions() {
.desc("Name of the collection.")
.build(),
Option.builder("out")
+ .deprecated(
+ DeprecatedAttributes.builder()
+ .setForRemoval(true)
+ .setSince("9.8")
+ .setDescription("Use --output instead")
+ .get())
+ .hasArg()
+ .argName("PATH")
+ .desc(
+ "Path to output the exported data, and optionally the file
name, defaults to 'collection-name'.")
+ .build(),
+ Option.builder()
+ .longOpt("output")
Review Comment:
If we deprecate and remove `-o` in `PostTool`'s `optimize` option, we could
use it here (listed in clig as common option). Only an idea though.
##########
solr/solr-ref-guide/modules/deployment-guide/pages/solr-control-script-reference.adoc:
##########
@@ -1634,16 +1634,27 @@ NOTE: The `export` command only works with in a Solr
running in cloud mode.
The `bin/solr export` command takes the following parameters:
-`--url <url>`::
+`--solr-url <url>`::
+
[%autowidth,frame=none]
|===
s|Required |Default: none
|===
+
-Fully-qualified address to a collection.
+Fully-qualified address to a Solr.
+
-*Example*: `--url http://localhost:8983/solr/techproducts`
+*Example*: `--solr-url http://localhost:8983`
+
+`-c <collection>`::
++
+[%autowidth,frame=none]
+|===
+s|Required |Default: none
+|===
++
+Name of the collection to run a export against.
Review Comment:
```suggestion
Name of the collection to run an export against.
```
##########
solr/packaging/test/test_basic_auth.bats:
##########
@@ -77,7 +77,7 @@ run solr create -c COLL_NAME
assert_output --partial 'Committed'
# Test export
- #run solr export -u name:password --solr-url "http://localhost:${SOLR_PORT}
--name COLL_NAME" -query "*:*" -out "${BATS_TEST_TMPDIR}/output"
+ #run solr export -u name:password --solr-url "http://localhost:${SOLR_PORT}
--name COLL_NAME" -query "*:*" --output "${BATS_TEST_TMPDIR}/output"
Review Comment:
Should we eventually remove this block if it is not executed? Otherwise here
is a small fix:
```suggestion
#run solr export -u name:password --solr-url http://localhost:${SOLR_PORT}
--name COLL_NAME --query "*:*" --output "${BATS_TEST_TMPDIR}/output"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
